From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH net-next v2] netdevsim: remove return value check of
 debugfs_create_dir
Date: Thu, 7 Dec 2017 22:03:30 -0800
Message-ID: <20171207220330.33106938@cakuba.netronome.com>
References: <20171208053218.4536-1-bhole_prashant_q7@lab.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt0-f181.google.com ([209.85.216.181]:37186 "EHLO
        mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750952AbdLHGDe (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 8 Dec 2017 01:03:34 -0500
Received: by mail-qt0-f181.google.com with SMTP id f2so23672777qtj.4
        for <netdev@vger.kernel.org>; Thu, 07 Dec 2017 22:03:34 -0800 (PST)
In-Reply-To: <20171208053218.4536-1-bhole_prashant_q7@lab.ntt.co.jp>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri,  8 Dec 2017 14:32:18 +0900, Prashant Bhole wrote:
> Reason:
> Discussion started about adding error check on return value where
> it was not handled. Also handling the error using IS_ERR_OR_NULL
> instead of IS_ERR(), because debugfs_create_dir() doesn't return
> error. It returns NULL or a valid pointer when DebugFS is enabled.
> 
> Finally it was decided to remove error handling altogether to
> make it consistent and removal of this check isn't fatal to the driver.
> 
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>

Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Thank you!