From: David Miller <davem@davemloft.net>
To: bhole_prashant_q7@lab.ntt.co.jp
Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com
Subject: Re: [PATCH net-next v2] netdevsim: remove return value check of debugfs_create_dir
Date: Fri, 08 Dec 2017 10:46:13 -0500 (EST) [thread overview]
Message-ID: <20171208.104613.2285331206958244059.davem@davemloft.net> (raw)
In-Reply-To: <20171208053218.4536-1-bhole_prashant_q7@lab.ntt.co.jp>
From: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Date: Fri, 8 Dec 2017 14:32:18 +0900
> Reason:
> Discussion started about adding error check on return value where
> it was not handled. Also handling the error using IS_ERR_OR_NULL
> instead of IS_ERR(), because debugfs_create_dir() doesn't return
> error. It returns NULL or a valid pointer when DebugFS is enabled.
>
> Finally it was decided to remove error handling altogether to
> make it consistent and removal of this check isn't fatal to the driver.
>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
I'm not apply this.
If it fails with NULL at init time the will potentially place
all the netdevsim device files in the ROOT of debugfs which
is strongly undesriable.
Check the errors, fix the debugfs interface error return semantics,
and make errors fatal for module load.
Thank you.
prev parent reply other threads:[~2017-12-08 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 5:32 [PATCH net-next v2] netdevsim: remove return value check of debugfs_create_dir Prashant Bhole
2017-12-08 6:03 ` Jakub Kicinski
2017-12-08 15:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208.104613.2285331206958244059.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).