From: David Miller <davem@davemloft.net>
To: claudiu.manoil@nxp.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, Shaohui.Xie@nxp.com
Subject: Re: [PATCH net] gianfar: Disable EEE autoneg by default
Date: Fri, 08 Dec 2017 13:23:24 -0500 (EST) [thread overview]
Message-ID: <20171208.132324.2253140746227286809.davem@davemloft.net> (raw)
In-Reply-To: <1512665063-1680-1-git-send-email-claudiu.manoil@nxp.com>
From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: Thu, 7 Dec 2017 18:44:23 +0200
> This controller does not support EEE, but it may connect to a PHY
> which supports EEE and advertises EEE by default, while its link
> partner also advertises EEE. If this happens, the PHY enters low
> power mode when the traffic rate is low and causes packet loss.
> This patch disables EEE advertisement by default for any PHY that
> gianfar connects to, to prevent the above unwanted outcome.
>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@nxp.com>
> Tested-by: Yangbo Lu <Yangbo.lu@nxp.com>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Applied, thank you.
prev parent reply other threads:[~2017-12-08 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 6:29 [PATCH] net: gianfar: add ethtool eee support Yangbo Lu
2017-11-28 13:15 ` Andrew Lunn
2017-12-07 16:44 ` [PATCH net] gianfar: Disable EEE autoneg by default Claudiu Manoil
2017-12-07 17:54 ` Andrew Lunn
2017-12-08 18:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208.132324.2253140746227286809.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Shaohui.Xie@nxp.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).