From: David Miller <davem@davemloft.net>
To: mkl@pengutronix.de
Cc: netdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] slip: sl_alloc(): remove unused parameter "dev_t line"
Date: Fri, 08 Dec 2017 14:43:12 -0500 (EST) [thread overview]
Message-ID: <20171208.144312.2056718125379523079.davem@davemloft.net> (raw)
In-Reply-To: <20171208111859.6090-1-mkl@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Fri, 8 Dec 2017 12:18:59 +0100
> The first and only parameter of sl_alloc() is unused, so remove it.
>
> Fixes: 5342b77c4123 slip: ("Clean up create and destroy")
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Applied.
While reviewing this I noticed that slip_devs[], along with the
arbitrary slip_maxdev limit, can be removed and replaced with
a simply linked list.
All the array is used for it proper teardown during module unload.
This is made even more clear by the fact that the index stored
in dev->base_addr is never ever used.
prev parent reply other threads:[~2017-12-08 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 11:18 [PATCH] slip: sl_alloc(): remove unused parameter "dev_t line" Marc Kleine-Budde
2017-12-08 11:22 ` Marc Kleine-Budde
2017-12-09 17:28 ` Oliver Hartkopp
2017-12-08 19:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208.144312.2056718125379523079.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).