From: Dan Carpenter <dan.carpenter@oracle.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: devel@linuxdriverproject.org, haiyangz@microsoft.com,
sthemmin@microsoft.com, netdev@vger.kernel.org
Subject: Re: [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size
Date: Fri, 8 Dec 2017 13:33:25 +0300 [thread overview]
Message-ID: <20171208103325.xt6nrzvxijewbdkl@mwanda> (raw)
In-Reply-To: <20171208001055.24670-2-sthemmin@microsoft.com>
On Thu, Dec 07, 2017 at 04:10:53PM -0800, Stephen Hemminger wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
>
> It should be 31 MB on recent host versions.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
This is very vague. What does "recent" mean in this context? There are
also some unrelated white space changes here which make the patch harder
to read.
This patch kind of makes the bug fixed by patch 2 even worse because
before the receive buffer was capped at around 16MB and now we can set
the receive buffer to 31MB. It might make sense to fold the two
patches together.
Is patch 2 a memory corruption bug? The changelog doesn't really say
what the user visible effects of the bug are. Basically if you make the
buffer too small then it's a performance issue but if you make it too
large what happens? It's not clear to me.
regards,
dan carpenter
next prev parent reply other threads:[~2017-12-08 10:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 0:10 [PATCH net 0/3] netvsc fix buffer size issues Stephen Hemminger
2017-12-08 0:10 ` [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size Stephen Hemminger
2017-12-08 10:33 ` Dan Carpenter [this message]
2017-12-08 16:03 ` David Miller
2017-12-08 16:11 ` Haiyang Zhang
2017-12-08 0:10 ` [PATCH net 2/3] hv_netvsc: Limit the receive buffer size for legacy hosts Stephen Hemminger
2017-12-08 0:10 ` [PATCH net 3/3] hv_netvsc: Fix the default receive buffer size Stephen Hemminger
2017-12-08 10:44 ` Dan Carpenter
2017-12-08 16:18 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208103325.xt6nrzvxijewbdkl@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox