From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
andrew.gospodarek@broadcom.com,
Ariel Elior <Ariel.Elior@cavium.com>,
everest-linux-l2@cavium.com
Subject: Re: [PATCH net-next v2 5/5] qede: Use NETIF_F_GRO_HW.
Date: Fri, 8 Dec 2017 20:09:22 -0200 [thread overview]
Message-ID: <20171208220922.GE3327@localhost.localdomain> (raw)
In-Reply-To: <1512633815-25037-6-git-send-email-michael.chan@broadcom.com>
Hi,
On Thu, Dec 07, 2017 at 03:03:35AM -0500, Michael Chan wrote:
> --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> @@ -940,6 +940,9 @@ int qede_change_mtu(struct net_device *ndev, int new_mtu)
> DP_VERBOSE(edev, (NETIF_MSG_IFUP | NETIF_MSG_IFDOWN),
> "Configuring MTU size of %d\n", new_mtu);
>
> + if (new_mtu > PAGE_SIZE)
I don't know the specs for this card but if it needs to fit the whole
packet in a page, maybe it should consider the ethernet header size in
such checks?
Marcelo
next prev parent reply other threads:[~2017-12-08 22:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 8:03 [PATCH net-next v2 0/5] Introduce NETIF_F_GRO_HW Michael Chan
2017-12-07 8:03 ` [PATCH net-next v2 1/5] net: " Michael Chan
2017-12-07 18:13 ` Alexander Duyck
2017-12-07 18:44 ` Michael Chan
2017-12-07 21:35 ` Alexander Duyck
2017-12-07 22:08 ` Michael Chan
2017-12-07 22:43 ` Alexander Duyck
2017-12-07 23:17 ` Michael Chan
2017-12-07 23:35 ` Alexander Duyck
2017-12-08 0:05 ` Michael Chan
2017-12-08 2:36 ` Alexander Duyck
2017-12-08 4:02 ` Michael Chan
2017-12-07 8:03 ` [PATCH net-next v2 2/5] net: Disable GRO_HW when generic XDP is installed on a device Michael Chan
2017-12-07 8:03 ` [PATCH net-next v2 3/5] bnxt_en: Use NETIF_F_GRO_HW Michael Chan
2017-12-07 8:03 ` [PATCH net-next v2 4/5] bnx2x: " Michael Chan
2017-12-07 8:03 ` [PATCH net-next v2 5/5] qede: " Michael Chan
2017-12-08 17:02 ` Chopra, Manish
2017-12-08 22:09 ` Marcelo Ricardo Leitner [this message]
2017-12-08 22:40 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208220922.GE3327@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=Ariel.Elior@cavium.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=everest-linux-l2@cavium.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).