* [PATCH] ptp: make PTP a menuconfig to ease disabling it all @ 2017-12-09 15:07 Vincent Legoll 2017-12-11 3:28 ` Richard Cochran 0 siblings, 1 reply; 4+ messages in thread From: Vincent Legoll @ 2017-12-09 15:07 UTC (permalink / raw) To: richardcochran, netdev, linux-kernel; +Cc: Vincent Legoll No need to get into the submenu to disable all PTP-related config entries. This makes it easier to disable all PTP config options without entering the submenu. It will also enable one to see that en/dis-abled state from the outside menu. This is only intended to change menuconfig UI, not change the config dependencies. Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com> --- drivers/ptp/Kconfig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index a21ad10d613c..d3f3a9f2b0b1 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -2,7 +2,10 @@ # PTP clock support configuration # -menu "PTP clock support" +menuconfig PTP_MENU + bool"PTP clock support" + +if PTP_MENU config PTP_1588_CLOCK tristate "PTP clock support" @@ -118,4 +121,4 @@ config PTP_1588_CLOCK_KVM To compile this driver as a module, choose M here: the module will be called ptp_kvm. -endmenu +endif # PTP_MENU -- 2.14.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ptp: make PTP a menuconfig to ease disabling it all 2017-12-09 15:07 [PATCH] ptp: make PTP a menuconfig to ease disabling it all Vincent Legoll @ 2017-12-11 3:28 ` Richard Cochran 2017-12-13 9:01 ` Vincent Legoll 0 siblings, 1 reply; 4+ messages in thread From: Richard Cochran @ 2017-12-11 3:28 UTC (permalink / raw) To: Vincent Legoll; +Cc: netdev, linux-kernel On Sat, Dec 09, 2017 at 04:07:15PM +0100, Vincent Legoll wrote: > No need to get into the submenu to disable all PTP-related > config entries. > > This makes it easier to disable all PTP config options > without entering the submenu. It will also enable one > to see that en/dis-abled state from the outside menu. > > This is only intended to change menuconfig UI, not change > the config dependencies. NAK, you are introducing a new config option for no good reason. Sorry, Richard ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ptp: make PTP a menuconfig to ease disabling it all 2017-12-11 3:28 ` Richard Cochran @ 2017-12-13 9:01 ` Vincent Legoll 2017-12-13 15:22 ` Richard Cochran 0 siblings, 1 reply; 4+ messages in thread From: Vincent Legoll @ 2017-12-13 9:01 UTC (permalink / raw) To: Richard Cochran; +Cc: netdev, Linux Kernel ML Hello, On Mon, Dec 11, 2017 at 4:28 AM, Richard Cochran <richardcochran@gmail.com> wrote: > NAK, you are introducing a new config option for no good reason. I don't think there are alternatives available in Kconfig to achieve the goal of easing the management of a .config with menuconfig. Do you have any idea about how to do it without using menuconfig ? Thanks -- Vincent Legoll ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ptp: make PTP a menuconfig to ease disabling it all 2017-12-13 9:01 ` Vincent Legoll @ 2017-12-13 15:22 ` Richard Cochran 0 siblings, 0 replies; 4+ messages in thread From: Richard Cochran @ 2017-12-13 15:22 UTC (permalink / raw) To: Vincent Legoll; +Cc: netdev, Linux Kernel ML On Wed, Dec 13, 2017 at 10:01:15AM +0100, Vincent Legoll wrote: > I don't think there are alternatives available in Kconfig to achieve > the goal of easing the management of a .config with menuconfig. > > Do you have any idea about how to do it without using menuconfig ? scripts/config HTH, Richard ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-13 15:22 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-12-09 15:07 [PATCH] ptp: make PTP a menuconfig to ease disabling it all Vincent Legoll 2017-12-11 3:28 ` Richard Cochran 2017-12-13 9:01 ` Vincent Legoll 2017-12-13 15:22 ` Richard Cochran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).