From mboxrd@z Thu Jan 1 00:00:00 1970 From: Solio Sarabia Subject: Re: [PATCH net-next 2/2] veth: set peer GSO values Date: Sat, 9 Dec 2017 11:51:13 -0800 Message-ID: <20171209195112.GA17500@ssarabia-MOBL7.amr.corp.intel.com> References: <20171207234020.18783-1-sthemmin@microsoft.com> <20171207234020.18783-3-sthemmin@microsoft.com> <3cc96c83-846d-7441-99b1-79947ca9fcd6@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: netdev@vger.kernel.org, sthemmin@microsoft.com, stephen@networkplumber.org, davem@davemloft.net To: David Ahern Return-path: Received: from mga04.intel.com ([192.55.52.120]:48321 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbdLITvO (ORCPT ); Sat, 9 Dec 2017 14:51:14 -0500 Content-Disposition: inline In-Reply-To: <3cc96c83-846d-7441-99b1-79947ca9fcd6@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Dec 09, 2017 at 09:41:25AM -0700, David Ahern wrote: > On 12/7/17 4:40 PM, Stephen Hemminger wrote: > > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > > index f5438d0978ca..a69ad39ee57e 100644 > > --- a/drivers/net/veth.c > > +++ b/drivers/net/veth.c > > @@ -410,6 +410,9 @@ static int veth_newlink(struct net *src_net, struct net_device *dev, > > if (ifmp && (dev->ifindex != 0)) > > peer->ifindex = ifmp->ifi_index; > > > > + peer->gso_max_size = dev->gso_max_size; > > + peer->gso_max_segs = dev->gso_max_segs; > > + > > err = register_netdevice(peer); > > put_net(net); > > net = NULL; > > > > What if gso changes are made after device create? They are not > propagated to the peer device like they are on link create. This would be a nice addition after ongoing patches are merged, since veth usually lives in another netns. For docker, it requires a couple of extra commands to expose the peer's netns.