From: Andrew Lunn <andrew@lunn.ch>
To: Kevin Cernekee <cernekee@chromium.org>
Cc: netdev@vger.kernel.org
Subject: Re: Incorrect source IP address on IGMP membership report
Date: Sat, 9 Dec 2017 23:20:08 +0100 [thread overview]
Message-ID: <20171209222008.GA11133@lunn.ch> (raw)
In-Reply-To: <CAJzqFtZW=kmebXZAvkpkKv9jcvEeb5YrSjQ4odCXUnkHwnO0Rw@mail.gmail.com>
> Hmm, RFC3376 says:
>
> 4.2.13. IP Source Addresses for Reports
>
> An IGMP report is sent with a valid IP source address for the
> destination subnet. The 0.0.0.0 source address may be used by a
> system that has not yet acquired an IP address. Note that the
> 0.0.0.0 source address may simultaneously be used by multiple systems
> on a LAN. Routers MUST accept a report with a source address of
> 0.0.0.0.
>
> Would it make sense to add a special case that says "zero out
> pip->saddr if the interface doesn't have any IPv4 addresses"? e.g.
Yes, this looks O.K. for IGMPv3.
Andrew
prev parent reply other threads:[~2017-12-09 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 5:25 Incorrect source IP address on IGMP membership report Kevin Cernekee
2017-12-09 16:01 ` Andrew Lunn
2017-12-09 20:32 ` Kevin Cernekee
2017-12-09 22:20 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171209222008.GA11133@lunn.ch \
--to=andrew@lunn.ch \
--cc=cernekee@chromium.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).