From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: Incorrect source IP address on IGMP membership report
Date: Sat, 9 Dec 2017 23:20:08 +0100
Message-ID: <20171209222008.GA11133@lunn.ch>
References: <CAJzqFtbXdrFYmRj7r1CF+1jH0KcH8EVG-yVdF3yMcAdzHWL5_A@mail.gmail.com>
 <20171209160116.GA2299@lunn.ch>
 <CAJzqFtZW=kmebXZAvkpkKv9jcvEeb5YrSjQ4odCXUnkHwnO0Rw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org
To: Kevin Cernekee <cernekee@chromium.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:54147 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751306AbdLIWUJ (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 9 Dec 2017 17:20:09 -0500
Content-Disposition: inline
In-Reply-To: <CAJzqFtZW=kmebXZAvkpkKv9jcvEeb5YrSjQ4odCXUnkHwnO0Rw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Hmm, RFC3376 says:
> 
> 4.2.13. IP Source Addresses for Reports
> 
>    An IGMP report is sent with a valid IP source address for the
>    destination subnet.  The 0.0.0.0 source address may be used by a
>    system that has not yet acquired an IP address.  Note that the
>    0.0.0.0 source address may simultaneously be used by multiple systems
>    on a LAN.  Routers MUST accept a report with a source address of
>    0.0.0.0.
> 
> Would it make sense to add a special case that says "zero out
> pip->saddr if the interface doesn't have any IPv4 addresses"?  e.g.

Yes, this looks O.K. for IGMPv3.

     Andrew