From mboxrd@z Thu Jan 1 00:00:00 1970 From: Solio Sarabia Subject: Re: [PATCH net-next] veth: fix setting peer gso values Date: Sat, 9 Dec 2017 17:16:28 -0800 Message-ID: <20171210011627.GA9224@ssarabia-MOBL7.amr.corp.intel.com> References: <1512846693-19983-1-git-send-email-solio.sarabia@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: netdev@vger.kernel.org, sthemmin@microsoft.com, shiny.sebastian@intel.com, solio.sarabia@intel.com To: davem@davemloft.net, stephen@networkplumber.org Return-path: Received: from mga17.intel.com ([192.55.52.151]:57120 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbdLJBQ3 (ORCPT ); Sat, 9 Dec 2017 20:16:29 -0500 Content-Disposition: inline In-Reply-To: <1512846693-19983-1-git-send-email-solio.sarabia@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Dec 09, 2017 at 11:11:33AM -0800, Solio Sarabia wrote: > GSO values are not correctly set for peer and dev. When creating > the veth link, GSO attributes are set for peer device, propagate > these values from peer to dev. > > Signed-off-by: Solio Sarabia > --- > drivers/net/veth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index a69ad39..d936c8a 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -410,8 +410,8 @@ static int veth_newlink(struct net *src_net, struct net_device *dev, > if (ifmp && (dev->ifindex != 0)) > peer->ifindex = ifmp->ifi_index; > > - peer->gso_max_size = dev->gso_max_size; > - peer->gso_max_segs = dev->gso_max_segs; > + dev->gso_max_size = peer->gso_max_size; > + dev->gso_max_segs = peer->gso_max_segs; Seems this patch won't be necessary after all. Parameter order in iproute2 util will be changed to set GSO on first dev device (not on the peer), making current code right: cloning from dev to peer. > > err = register_netdevice(peer); > put_net(net); > -- > 2.7.4 >