From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: igor.russkikh@aquantia.com, netdev@vger.kernel.org,
darcari@redhat.com, pavel.belous@aquantia.com,
Nadezhda.Krupnina@aquantia.com, simon.edelhaus@aquantia.com
Subject: Re: [PATCH net v2 8/9] net: aquantia: Fix typo in ethtool statistics names
Date: Mon, 11 Dec 2017 10:51:03 -0500 (EST) [thread overview]
Message-ID: <20171211.105103.905385732602210885.davem@davemloft.net> (raw)
In-Reply-To: <20171211154506.GG28672@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Mon, 11 Dec 2017 16:45:06 +0100
> I know it is not nice, but maybe we need to consider this is part of
> the kernel ABI? You could be breaking applications by making this
> change.
>
> What do others think?
Not really.
The whole reason we have a string array exposed to userspace is so that
tools absolutely cannot hard code the driver specific ethtool stats
in any way shape or form, and must always query the number, order,
and names every single time.
next prev parent reply other threads:[~2017-12-11 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 12:16 [PATCH net v2 0/9] net: aquantia: Atlantic driver 12/2017 updates Igor Russkikh
2017-12-11 12:16 ` [PATCH net v2 1/9] net: aquantia: Fix actual speed capabilities reporting Igor Russkikh
2017-12-11 12:16 ` [PATCH net v2 2/9] net: aquantia: Fix hardware DMA stream overload on large MRRS Igor Russkikh
2017-12-11 12:16 ` [PATCH net v2 3/9] net: aquantia: Extend stat counters to 64bit values Igor Russkikh
2017-12-11 12:16 ` [PATCH net v2 4/9] net: aquantia: Fill ndev stat couters from hardware Igor Russkikh
2017-12-11 15:47 ` Andrew Lunn
2017-12-11 12:16 ` [PATCH net v2 5/9] net: aquantia: Fill in multicast counter in ndev stats " Igor Russkikh
2017-12-11 15:46 ` Andrew Lunn
2017-12-11 12:16 ` [PATCH net v2 6/9] net: aquantia: Improve link state and statistics check interval callback Igor Russkikh
2017-12-11 12:16 ` [PATCH net v2 7/9] net: aquantia: Reset driver level statistics to zero on initialization Igor Russkikh
2017-12-11 15:51 ` Andrew Lunn
2017-12-12 9:46 ` Igor Russkikh
2017-12-11 12:16 ` [PATCH net v2 8/9] net: aquantia: Fix typo in ethtool statistics names Igor Russkikh
2017-12-11 15:45 ` Andrew Lunn
2017-12-11 15:51 ` David Miller [this message]
2017-12-11 12:16 ` [PATCH net v2 9/9] net: aquantia: Increment driver version Igor Russkikh
2017-12-11 15:45 ` [PATCH net v2 0/9] net: aquantia: Atlantic driver 12/2017 updates Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211.105103.905385732602210885.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Nadezhda.Krupnina@aquantia.com \
--cc=andrew@lunn.ch \
--cc=darcari@redhat.com \
--cc=igor.russkikh@aquantia.com \
--cc=netdev@vger.kernel.org \
--cc=pavel.belous@aquantia.com \
--cc=simon.edelhaus@aquantia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).