From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 5/6] net: qualcomm: rmnet: Allow to
 configure flags for new devices
Date: Mon, 11 Dec 2017 12:18:52 -0500 (EST)
Message-ID: <20171211.121852.804410408823633381.davem@davemloft.net>
References: <1512853110-4893-1-git-send-email-subashab@codeaurora.org>
        <1512853110-4893-6-git-send-email-subashab@codeaurora.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: subashab@codeaurora.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:37162 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752340AbdLKRSy (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 11 Dec 2017 12:18:54 -0500
In-Reply-To: <1512853110-4893-6-git-send-email-subashab@codeaurora.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Date: Sat,  9 Dec 2017 13:58:29 -0700

> @@ -312,7 +321,8 @@ static int rmnet_rtnl_validate(struct nlattr *tb[], struct nlattr *data[],
>  
>  static size_t rmnet_get_size(const struct net_device *dev)
>  {
> -	return nla_total_size(2); /* IFLA_VLAN_ID */
> +	return nla_total_size(2) /* IFLA_VLAN_ID */ +
> +	nla_total_size(sizeof(struct ifla_vlan_flags)); /* IFLA_VLAN_FLAGS */
>  }
>  

Please indent this return statement properly, the second line of the
expression definitely should not start at the same column as the
'return'.

Thank you.