From: David Miller <davem@davemloft.net>
To: yanjun.zhu@oracle.com
Cc: netdev@vger.kernel.org, keescook@chromium.org
Subject: Re: [PATCHv2 net-next 1/1] forcedeth: remove unnecessary structure member
Date: Mon, 11 Dec 2017 14:04:29 -0500 (EST) [thread overview]
Message-ID: <20171211.140429.1510398539345216417.davem@davemloft.net> (raw)
In-Reply-To: <1512875246-28258-1-git-send-email-yanjun.zhu@oracle.com>
From: Zhu Yanjun <yanjun.zhu@oracle.com>
Date: Sat, 9 Dec 2017 22:07:26 -0500
> Since both tx_ring and first_tx are the head of tx ring, it not
> necessary to use two structure members to statically indicate
> the head of tx ring. So first_tx is removed.
>
> CC: Srinivas Eeda <srinivas.eeda@oracle.com>
> CC: Joe Jin <joe.jin@oracle.com>
> CC: Junxiao Bi <junxiao.bi@oracle.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
I suspect this extraneous member was meant to be used for multiqueue
support or something like that.
But, it never got really used, and your change is correct.
Applied, thanks.
prev parent reply other threads:[~2017-12-11 19:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 4:15 [PATCH net-next 1/1] forcedeth: remove unnecessary variable Zhu Yanjun
2017-12-07 19:07 ` David Miller
2017-12-08 2:11 ` Yanjun Zhu
2017-12-10 3:07 ` [PATCHv2 net-next 1/1] forcedeth: remove unnecessary structure member Zhu Yanjun
2017-12-11 19:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211.140429.1510398539345216417.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=yanjun.zhu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).