From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net v2 8/9] net: aquantia: Fix typo in ethtool statistics
 names
Date: Mon, 11 Dec 2017 16:45:06 +0100
Message-ID: <20171211154506.GG28672@lunn.ch>
References: <cover.1512994559.git.igor.russkikh@aquantia.com>
 <77ee1884039b2c73fb7542144931e30bdcb2de7f.1512994559.git.igor.russkikh@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        David Arcari <darcari@redhat.com>,
        Pavel Belous <pavel.belous@aquantia.com>,
        Nadezhda Krupnina <Nadezhda.Krupnina@aquantia.com>,
        Simon Edelhaus <simon.edelhaus@aquantia.com>
To: Igor Russkikh <igor.russkikh@aquantia.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:56957 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752546AbdLKPpL (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 11 Dec 2017 10:45:11 -0500
Content-Disposition: inline
In-Reply-To: <77ee1884039b2c73fb7542144931e30bdcb2de7f.1512994559.git.igor.russkikh@aquantia.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Dec 11, 2017 at 03:16:25PM +0300, Igor Russkikh wrote:
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
> ---
>  drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
> index 70efb74..f2d8063 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
> @@ -66,14 +66,14 @@ static const char aq_ethtool_stat_names[][ETH_GSTRING_LEN] = {
>  	"OutUCast",
>  	"OutMCast",
>  	"OutBCast",
> -	"InUCastOctects",
> -	"OutUCastOctects",
> -	"InMCastOctects",
> -	"OutMCastOctects",
> -	"InBCastOctects",
> -	"OutBCastOctects",
> -	"InOctects",
> -	"OutOctects",
> +	"InUCastOctets",
> +	"OutUCastOctets",
> +	"InMCastOctets",
> +	"OutMCastOctets",
> +	"InBCastOctets",
> +	"OutBCastOctets",
> +	"InOctets",
> +	"OutOctets",
>  	"InPacketsDma",
>  	"OutPacketsDma",
>  	"InOctetsDma",

Hi Igor

I know it is not nice, but maybe we need to consider this is part of
the kernel ABI? You could be breaking applications by making this
change.

What do others think?

	Andrew