From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] veth: Optionally pad packets to minimum Ethernet length
Date: Tue, 12 Dec 2017 14:01:27 -0800
Message-ID: <20171212140127.15bb8b73@xeon-e3>
References: <1513095191-127313-1-git-send-email-eswierk@skyportsystems.com>
        <1513099966.26538.1.camel@redhat.com>
        <20171212181817.GB3531@localhost.localdomain>
        <20171212103423.508ad7c9@xeon-e3>
        <CAO_EM_m6XGoCRQPzYM36uP+MdQHQ6rPDY05eJyqkBTT8pjastA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
        Dan Williams <dcbw@redhat.com>,
        netdev <netdev@vger.kernel.org>,
        Benjamin Warren <ben@skyportsystems.com>,
        Keith Holleman <holleman@skyportsystems.com>
To: Ed Swierk <eswierk@skyportsystems.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f46.google.com ([74.125.83.46]:39966 "EHLO
        mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752603AbdLLWBa (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 12 Dec 2017 17:01:30 -0500
Received: by mail-pg0-f46.google.com with SMTP id k15so250432pgr.7
        for <netdev@vger.kernel.org>; Tue, 12 Dec 2017 14:01:30 -0800 (PST)
In-Reply-To: <CAO_EM_m6XGoCRQPzYM36uP+MdQHQ6rPDY05eJyqkBTT8pjastA@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 12 Dec 2017 11:00:38 -0800
Ed Swierk <eswierk@skyportsystems.com> wrote:

> On Tue, Dec 12, 2017 at 10:34 AM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > Why not add to netdevsim rather than cluttering up a normal driver
> > with test support.  We just pulled a bunch of test stuff out of dummy
> > for the same reason.  
> 
> My test setup to trigger an openvswitch conntrack issue
> (https://marc.info/?l=linux-netdev&m=151309548725627) involves a lot
> of moving parts:
> 
> [netns-a: vetha1] - [vetha0] - [ovsbr0] - [vethb0] - [netns-b: vethb1]
> 
> with nc client and server in netns-a and -b, and tweaks like turning
> off tcp_timestamps to make sure the packets in the TCP stream are
> small enough to reproduce the problem. A simpler, less fragile test
> setup would be valuable, especially if it ends up as an automated
> regression test.
> 
> Could netdevsim be useful for that? Are there any existing tests
> producing TCP traffic that might serve as an example?
> 
> --Ed

Maybe add a netem impairment that does padding?