From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 iproute2 net-next] gre6: add collect metadata support Date: Tue, 12 Dec 2017 17:40:02 -0800 Message-ID: <20171212174002.225f0a53@xeon-e3> References: <1513127243-82244-1-git-send-email-u9012063@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Daniel Borkmann To: William Tu Return-path: Received: from mail-pf0-f169.google.com ([209.85.192.169]:42244 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdLMBkF (ORCPT ); Tue, 12 Dec 2017 20:40:05 -0500 Received: by mail-pf0-f169.google.com with SMTP id d23so628791pfe.9 for ; Tue, 12 Dec 2017 17:40:04 -0800 (PST) In-Reply-To: <1513127243-82244-1-git-send-email-u9012063@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 12 Dec 2017 17:07:23 -0800 William Tu wrote: > +.RB external > +- make this tunnel externally controlled (or not, which is the default). > +This is also known as collect_metadata mode for tunnels. Much better. The man page still needs some work. The phrase "is also known as" is a little confusing and putting a specific variable name in man page is misleading. Maybe better wording would be: In the kernel, this is referred to as collect metadata mode.