From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH net] skge: remove redundunt free_irq under spinlock Date: Tue, 12 Dec 2017 10:30:29 -0800 Message-ID: <20171212183029.28684-1-sthemmin@microsoft.com> Cc: netdev@vger.kernel.org, Stephen Hemminger , Stephen Hemminger To: davem@davemloft.net Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:43177 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbdLLSad (ORCPT ); Tue, 12 Dec 2017 13:30:33 -0500 Received: by mail-pf0-f195.google.com with SMTP id e3so14829214pfi.10 for ; Tue, 12 Dec 2017 10:30:33 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: The code to handle multi-port SKGE boards was freeing IRQ twice. The first one was under lock and might sleep. Signed-off-by: Stephen Hemminger --- Given that multi-port SKGE devices are very old and unlikely to still be in use. This patch does not need to go to stable. drivers/net/ethernet/marvell/skge.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 6e423f098a60..31efc47c847e 100644 --- a/drivers/net/ethernet/marvell/skge.c +++ b/drivers/net/ethernet/marvell/skge.c @@ -4081,7 +4081,6 @@ static void skge_remove(struct pci_dev *pdev) if (hw->ports > 1) { skge_write32(hw, B0_IMSK, 0); skge_read32(hw, B0_IMSK); - free_irq(pdev->irq, hw); } spin_unlock_irq(&hw->hw_lock); -- 2.11.0