From: David Miller <davem@davemloft.net>
To: branislav@radocaj.org
Cc: heiko@sntech.de, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: ethernet: arc: fix error handling in emac_rockchip_probe
Date: Wed, 13 Dec 2017 13:58:09 -0500 (EST) [thread overview]
Message-ID: <20171213.135809.2249165364822346437.davem@davemloft.net> (raw)
In-Reply-To: <20171211231338.5207-1-branislav@radocaj.org>
From: Branislav Radocaj <branislav@radocaj.org>
Date: Tue, 12 Dec 2017 00:13:38 +0100
> If clk_set_rate() fails, we should disable clk before return.
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Changes since v2 [1]:
> * Merged with latest code changes
>
> Changes since v1:
> Update made thanks to David's review, much appreciated David.
> * Improved inconsistent failure handling of clock rate setting
> * For completeness of usecase, added arc_emac_probe error handling
>
> Signed-off-by: Branislav Radocaj <branislav@radocaj.org>
Applied.
prev parent reply other threads:[~2017-12-13 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 23:13 [PATCH v3] net: ethernet: arc: fix error handling in emac_rockchip_probe Branislav Radocaj
2017-12-13 18:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213.135809.2249165364822346437.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=branislav@radocaj.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox