From: David Miller <davem@davemloft.net>
To: baijiaju1990@163.com
Cc: jes@trained-monkey.org, jes@wildopensource.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close
Date: Wed, 13 Dec 2017 14:53:19 -0500 (EST) [thread overview]
Message-ID: <20171213.145319.1650448955612362760.davem@davemloft.net> (raw)
In-Reply-To: <1513068592-23632-1-git-send-email-baijiaju1990@163.com>
From: Jia-Ju Bai <baijiaju1990@163.com>
Date: Tue, 12 Dec 2017 16:49:52 +0800
> The driver may sleep under a spinlock.
> The function call path is:
> rr_close (acquire the spinlock)
> free_irq --> may sleep
>
> To fix it, free_irq is moved to the place without holding the spinlock.
>
> This bug is found by my static analysis tool(DSAC) and checked by my code review.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Applied.
prev parent reply other threads:[~2017-12-13 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 8:49 [PATCH] hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close Jia-Ju Bai
2017-12-13 19:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213.145319.1650448955612362760.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baijiaju1990@163.com \
--cc=jes@trained-monkey.org \
--cc=jes@wildopensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox