From: David Miller <davem@davemloft.net>
To: alexey.kodanev@oracle.com
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com,
pvorel@suse.cz, shannon.nelson@oracle.com
Subject: Re: [PATCH net-next v2] ip6_vti: adjust vti mtu according to mtu of output device
Date: Wed, 13 Dec 2017 15:09:33 -0500 (EST) [thread overview]
Message-ID: <20171213.150933.145602207446562231.davem@davemloft.net> (raw)
In-Reply-To: <1513086812-24896-1-git-send-email-alexey.kodanev@oracle.com>
From: Alexey Kodanev <alexey.kodanev@oracle.com>
Date: Tue, 12 Dec 2017 16:53:32 +0300
> + if (tdev) {
> + dev->mtu = max_t(int, tdev->mtu - dev->hard_header_len,
> + IPV6_MIN_MTU);
> + }
Please don't use curly braces for a single-statement basic block.
Thank you.
prev parent reply other threads:[~2017-12-13 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 13:53 [PATCH net-next v2] ip6_vti: adjust vti mtu according to mtu of output device Alexey Kodanev
2017-12-12 17:53 ` Shannon Nelson
2017-12-13 20:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213.150933.145602207446562231.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.kodanev@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=shannon.nelson@oracle.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox