From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: nbd@nbd.name, netdev@vger.kernel.org, johannes.berg@intel.com,
toke@toke.dk, kir@openvz.org
Subject: Re: [PATCH net-next] net: sk_pacing_shift_update() helper
Date: Wed, 13 Dec 2017 15:11:10 -0500 (EST) [thread overview]
Message-ID: <20171213.151110.2067805288863733715.davem@davemloft.net> (raw)
In-Reply-To: <1513089259.25033.51.camel@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 12 Dec 2017 06:34:19 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> In commit 3a9b76fd0db9 ("tcp: allow drivers to tweak TSQ logic")
> I gave a code sample to set sk->sk_pacing_shift that was not complete.
>
> Better add a helper that can be used by drivers without worries,
> and maybe amended in the future.
>
> A wifi driver might use it from its ndo_start_xmit()
>
> Following call would setup TCP to allow up to ~8ms of queued data per
> flow.
>
> sk_pacing_shift_update(skb->sk, 7);
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2017-12-13 20:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 2:41 [PATCH net-next] tcp: allow drivers to tweak TSQ logic Eric Dumazet
2017-11-11 14:27 ` [net-next] " Johannes Berg
2017-11-11 23:38 ` Eric Dumazet
2017-11-13 9:21 ` Johannes Berg
2017-11-12 14:35 ` Toke Høiland-Jørgensen
2017-11-11 23:54 ` [PATCH v2 net-next] " Eric Dumazet
2017-11-12 13:39 ` Neal Cardwell
2017-11-14 7:18 ` David Miller
2017-11-28 13:10 ` Felix Fietkau
2017-11-28 17:33 ` Eric Dumazet
2017-12-12 14:34 ` [PATCH net-next] net: sk_pacing_shift_update() helper Eric Dumazet
2017-12-13 20:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213.151110.2067805288863733715.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kir@openvz.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).