Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ycheng@google.com
Cc: netdev@vger.kernel.org, edumazet@google.com,
	ncardwell@google.com, weiwan@google.com, cpaasch@apple.com,
	ddamjanovic@mozilla.com, mcmanus@ducksong.com
Subject: Re: [PATH net-next] tcp: pause Fast Open globally after third consecutive timeout
Date: Wed, 13 Dec 2017 15:51:38 -0500 (EST)	[thread overview]
Message-ID: <20171213.155138.401295393122455021.davem@davemloft.net> (raw)
In-Reply-To: <20171212211040.222118-1-ycheng@google.com>

From: Yuchung Cheng <ycheng@google.com>
Date: Tue, 12 Dec 2017 13:10:40 -0800

> Prior to this patch, active Fast Open is paused on a specific
> destination IP address if the previous connections to the
> IP address have experienced recurring timeouts . But recent
> experiments by Microsoft (https://goo.gl/cykmn7) and Mozilla
> browsers indicate the isssue is often caused by broken middle-boxes
> sitting close to the client. Therefore it is much better user
> experience if Fast Open is disabled out-right globally to avoid
> experiencing further timeouts on connections toward other
> destinations.
> 
> This patch changes the destination-IP disablement to global
> disablement if a connection experiencing recurring timeouts
> or aborts due to timeout.  Repeated incidents would still
> exponentially increase the pause time, starting from an hour.
> This is extremely conservative but an unfortunate compromise to
> minimize bad experience due to broken middle-boxes.
> 
> Reported-by: Dragana Damjanovic <ddamjanovic@mozilla.com>
> Reported-by: Patrick McManus <mcmanus@ducksong.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> Reviewed-by: Wei Wang <weiwan@google.com>
> Reviewed-by: Neal Cardwell <ncardwell@google.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>

Very unfortunate, but I can't suggest anything better at this time.

Applied, thank you.

      reply	other threads:[~2017-12-13 20:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 21:10 [PATH net-next] tcp: pause Fast Open globally after third consecutive timeout Yuchung Cheng
2017-12-13 20:51 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213.155138.401295393122455021.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cpaasch@apple.com \
    --cc=ddamjanovic@mozilla.com \
    --cc=edumazet@google.com \
    --cc=mcmanus@ducksong.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=weiwan@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox