From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks Date: Wed, 13 Dec 2017 16:04:47 -0500 (EST) Message-ID: <20171213.160447.126875023972302023.davem@davemloft.net> References: <1513131772.25033.60.camel@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, soheil@google.com, ncardwell@google.com, maloney@google.com To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45110 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbdLMVEt (ORCPT ); Wed, 13 Dec 2017 16:04:49 -0500 In-Reply-To: <1513131772.25033.60.camel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Tue, 12 Dec 2017 18:22:52 -0800 > From: Eric Dumazet > > Only the retransmit timer currently refreshes tcp_mstamp > > We should do the same for delayed acks and keepalives. > > Even if RFC 7323 does not request it, this is consistent to what linux > did in the past, when TS values were based on jiffies. > > Fixes: 385e20706fac ("tcp: use tp->tcp_mstamp in output path") > Signed-off-by: Eric Dumazet Applied and queued up for -stable, thanks Eric.