From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: [PATCH net-next v2 2/5] net: phy: phylink: Use PHY device interface if N/A Date: Tue, 12 Dec 2017 16:00:26 -0800 Message-ID: <20171213000029.8649-3-f.fainelli@gmail.com> References: <20171213000029.8649-1-f.fainelli@gmail.com> Cc: Florian Fainelli , rmk+kernel@armlinux.org.uk, davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com To: netdev@vger.kernel.org Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:33586 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144AbdLMAAi (ORCPT ); Tue, 12 Dec 2017 19:00:38 -0500 Received: by mail-oi0-f66.google.com with SMTP id w131so458202oiw.0 for ; Tue, 12 Dec 2017 16:00:38 -0800 (PST) In-Reply-To: <20171213000029.8649-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: We may not always be able to resolve a correct phy_interface_t value before actually connecting to the PHY device, when that happens, just have phylink_connect_phy() utilize what the PHY device/driver provided. Signed-off-by: Florian Fainelli --- drivers/net/phy/phylink.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 94b43c5237fa..60c1b7e5490e 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -715,6 +715,12 @@ int phylink_connect_phy(struct phylink *pl, struct phy_device *phy) phy_interface_mode_is_8023z(pl->link_interface)))) return -EINVAL; + /* Use PHY device/driver interface */ + if (pl->link_interface == PHY_INTERFACE_MODE_NA) { + pl->link_interface = phy->interface; + pl->link_config.interface = pl->link_interface; + } + ret = phy_attach_direct(pl->netdev, phy, 0, pl->link_interface); if (ret) return ret; -- 2.14.1