From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
rmk+kernel@armlinux.org.uk, davem@davemloft.net, andrew@lunn.ch,
vivien.didelot@savoirfairelinux.com
Subject: [PATCH net-next v2 3/5] net: phy: phylink: Remove error message
Date: Tue, 12 Dec 2017 16:00:27 -0800 [thread overview]
Message-ID: <20171213000029.8649-4-f.fainelli@gmail.com> (raw)
In-Reply-To: <20171213000029.8649-1-f.fainelli@gmail.com>
Some subsystems like DSA may be trying to connect to a PHY through OF first,
and then attempt a connect using a local MDIO bus, remove the error message:
"unable to find PHY node" so we can let MAC drivers whether to print it or not.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/phylink.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 60c1b7e5490e..64e3eb73a237 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -765,10 +765,8 @@ int phylink_of_phy_connect(struct phylink *pl, struct device_node *dn,
phy_node = of_parse_phandle(dn, "phy-device", 0);
if (!phy_node) {
- if (pl->link_an_mode == MLO_AN_PHY) {
- netdev_err(pl->netdev, "unable to find PHY node\n");
+ if (pl->link_an_mode == MLO_AN_PHY)
return -ENODEV;
- }
return 0;
}
--
2.14.1
next prev parent reply other threads:[~2017-12-13 0:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 0:00 [PATCH net-next v2 0/5] PHYLINK preparatory patches for DSA Florian Fainelli
2017-12-13 0:00 ` [PATCH net-next v2 1/5] net: phy: phylink: Allow specifying PHY device flags Florian Fainelli
2017-12-13 16:54 ` Andrew Lunn
2017-12-13 0:00 ` [PATCH net-next v2 2/5] net: phy: phylink: Use PHY device interface if N/A Florian Fainelli
2017-12-13 0:00 ` Florian Fainelli [this message]
2017-12-13 16:56 ` [PATCH net-next v2 3/5] net: phy: phylink: Remove error message Andrew Lunn
2017-12-13 0:00 ` [PATCH net-next v2 4/5] net: phy: phylink: Allow setting a custom link state callback Florian Fainelli
2017-12-13 16:58 ` Andrew Lunn
2017-12-13 0:00 ` [PATCH net-next v2 5/5] net: phy: phylink: Report MoCA as PORT_BNC Florian Fainelli
2017-12-13 16:59 ` Andrew Lunn
2017-12-13 20:55 ` [PATCH net-next v2 0/5] PHYLINK preparatory patches for DSA David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213000029.8649-4-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).