From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: [PATCH net-next v2 3/5] net: phy: phylink: Remove error message Date: Tue, 12 Dec 2017 16:00:27 -0800 Message-ID: <20171213000029.8649-4-f.fainelli@gmail.com> References: <20171213000029.8649-1-f.fainelli@gmail.com> Cc: Florian Fainelli , rmk+kernel@armlinux.org.uk, davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com To: netdev@vger.kernel.org Return-path: Received: from mail-oi0-f67.google.com ([209.85.218.67]:45091 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbdLMAAk (ORCPT ); Tue, 12 Dec 2017 19:00:40 -0500 Received: by mail-oi0-f67.google.com with SMTP id x20so430491oix.12 for ; Tue, 12 Dec 2017 16:00:40 -0800 (PST) In-Reply-To: <20171213000029.8649-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Some subsystems like DSA may be trying to connect to a PHY through OF first, and then attempt a connect using a local MDIO bus, remove the error message: "unable to find PHY node" so we can let MAC drivers whether to print it or not. Signed-off-by: Florian Fainelli --- drivers/net/phy/phylink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 60c1b7e5490e..64e3eb73a237 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -765,10 +765,8 @@ int phylink_of_phy_connect(struct phylink *pl, struct device_node *dn, phy_node = of_parse_phandle(dn, "phy-device", 0); if (!phy_node) { - if (pl->link_an_mode == MLO_AN_PHY) { - netdev_err(pl->netdev, "unable to find PHY node\n"); + if (pl->link_an_mode == MLO_AN_PHY) return -ENODEV; - } return 0; } -- 2.14.1