From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v3 00/10] net: sched: allow qdiscs to share filter block instances Date: Wed, 13 Dec 2017 18:07:57 +0100 Message-ID: <20171213170757.GJ2031@nanopsycho> References: <20171213151038.29665-1-jiri@resnulli.us> <04bcfa37-a74e-9e2f-3ac1-7ed8e63e13df@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: David Ahern Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:45678 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753189AbdLMRIA (ORCPT ); Wed, 13 Dec 2017 12:08:00 -0500 Received: by mail-wm0-f67.google.com with SMTP id 9so6391508wme.4 for ; Wed, 13 Dec 2017 09:07:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <04bcfa37-a74e-9e2f-3ac1-7ed8e63e13df@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Dec 13, 2017 at 05:54:35PM CET, dsahern@gmail.com wrote: >On 12/13/17 8:10 AM, Jiri Pirko wrote: >> So back to the example. First, we create 2 qdiscs. Both will share >> block number 22. "22" is just an identification. If we don't pass any >> block number, a new one will be generated by kernel: >> >> $ tc qdisc add dev ens7 ingress block 22 >> ^^^^^^^^ >> $ tc qdisc add dev ens8 ingress block 22 >> ^^^^^^^^ >> >> Now if we list the qdiscs, we will see the block index in the output: >> >> $ tc qdisc >> qdisc ingress ffff: dev ens7 parent ffff:fff1 block 22 >> qdisc ingress ffff: dev ens8 parent ffff:fff1 block 22 >> >> To make is more visual, the situation looks like this: >> >> ens7 ingress qdisc ens7 ingress qdisc >> | | >> | | >> +----------> block 22 <----------+ >> >> Unlimited number of qdiscs may share the same block. >> >> Now we can add filter to any of qdiscs sharing the same block: >> >> $ tc filter add dev ens7 ingress protocol ip pref 25 flower dst_ip 192.168.0.0/16 action drop > >I still say this is very odd user semantic - making changes to device M >and the changes magically affect device N. Operating on the shared block >as a separate object makes it is much more direct and clear. I plan to do it as a follow-up patch. But this is how things are done now and have to continue to work. Also changes done on dev block X for dev A has to appear in block X for dev B. Block X is share between A and B.