Re: net: phy: consolidate PHY reset in phy_init_hw()

Re: net: phy: consolidate PHY reset in phy_init_hw()

[Daniel Walker]

Hi,

https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608

I've got a machine with an Marvell 88EE1112 , and it seems this patch 
causes a problem. When the reset happens under this code this phy always 
returns -ETIMEDOUT from inside phy_poll_reset() .. It would seem this 
phy doesn't fit whatever standard this code is expecting. I tried to 
increase the wait time, but it doesn't seems to change anything.

Any thoughts?

Daniel

Re: net: phy: consolidate PHY reset in phy_init_hw()

[Andrew Lunn]

On Wed, Dec 13, 2017 at 10:46:02AM -0800, Daniel Walker wrote:
> 
> Hi,
> 
> https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608

Hi Daniel

This is a 4 year old patch, so i'm kind of surprised nobody noticed
this before. How did you conclude this patch is the problem?

     Thanks
	Andrew

Re: net: phy: consolidate PHY reset in phy_init_hw()

[Daniel Walker]

On 12/13/2017 12:35 PM, Andrew Lunn wrote:
> On Wed, Dec 13, 2017 at 10:46:02AM -0800, Daniel Walker wrote:
>> Hi,
>>
>> https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608
> Hi Daniel
>
> This is a 4 year old patch, so i'm kind of surprised nobody noticed
> this before. How did you conclude this patch is the problem?
>
>       Thanks
> 	Andrew


I just did some debugging to find the -ETIMEDOUT error message which I 
tracked back to the waiting routine inside this patch. I did do a high 
level bisect jumping between major versions, and the issue seemed to go 
away around the time when this patch was added. v3.10 didn't have it, 
and one of the version of the kernel immediately after had it, either 
v3.11 or v3.12 ..

This phy may not be used often, that might be part of it.


Daniel