* Re: net: phy: consolidate PHY reset in phy_init_hw()
@ 2017-12-13 18:46 Daniel Walker
2017-12-13 20:35 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Walker @ 2017-12-13 18:46 UTC (permalink / raw)
To: Florian Fainelli, David S. Miller, netdev@vger.kernel.org
Hi,
https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608
I've got a machine with an Marvell 88EE1112 , and it seems this patch
causes a problem. When the reset happens under this code this phy always
returns -ETIMEDOUT from inside phy_poll_reset() .. It would seem this
phy doesn't fit whatever standard this code is expecting. I tried to
increase the wait time, but it doesn't seems to change anything.
Any thoughts?
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: net: phy: consolidate PHY reset in phy_init_hw()
2017-12-13 18:46 net: phy: consolidate PHY reset in phy_init_hw() Daniel Walker
@ 2017-12-13 20:35 ` Andrew Lunn
2017-12-13 21:03 ` Daniel Walker
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2017-12-13 20:35 UTC (permalink / raw)
To: Daniel Walker; +Cc: Florian Fainelli, David S. Miller, netdev@vger.kernel.org
On Wed, Dec 13, 2017 at 10:46:02AM -0800, Daniel Walker wrote:
>
> Hi,
>
> https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608
Hi Daniel
This is a 4 year old patch, so i'm kind of surprised nobody noticed
this before. How did you conclude this patch is the problem?
Thanks
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: net: phy: consolidate PHY reset in phy_init_hw()
2017-12-13 20:35 ` Andrew Lunn
@ 2017-12-13 21:03 ` Daniel Walker
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Walker @ 2017-12-13 21:03 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Florian Fainelli, David S. Miller, netdev@vger.kernel.org
On 12/13/2017 12:35 PM, Andrew Lunn wrote:
> On Wed, Dec 13, 2017 at 10:46:02AM -0800, Daniel Walker wrote:
>> Hi,
>>
>> https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608
> Hi Daniel
>
> This is a 4 year old patch, so i'm kind of surprised nobody noticed
> this before. How did you conclude this patch is the problem?
>
> Thanks
> Andrew
I just did some debugging to find the -ETIMEDOUT error message which I
tracked back to the waiting routine inside this patch. I did do a high
level bisect jumping between major versions, and the issue seemed to go
away around the time when this patch was added. v3.10 didn't have it,
and one of the version of the kernel immediately after had it, either
v3.11 or v3.12 ..
This phy may not be used often, that might be part of it.
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-13 21:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-13 18:46 net: phy: consolidate PHY reset in phy_init_hw() Daniel Walker
2017-12-13 20:35 ` Andrew Lunn
2017-12-13 21:03 ` Daniel Walker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).