From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mi Subject: [patch iproute2] tc: fix command "tc actions del" hang issue Date: Thu, 14 Dec 2017 18:09:00 +0900 Message-ID: <20171214090900.14336-1-chrism@mellanox.com> Cc: jiri@resnulli.us To: netdev@vger.kernel.org Return-path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:50184 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750941AbdLNJJY (ORCPT ); Thu, 14 Dec 2017 04:09:24 -0500 Sender: netdev-owner@vger.kernel.org List-ID: If command is RTM_DELACTION, a non-NULL pointer is passed to rtnl_talk(). Then flag NLM_F_ACK is not set on n->nlmsg_flags and netlink_ack() will not be called. Command tc will wait for the reply for ever. Fixes: 86bf43c7c2fd ("lib/libnetlink: update rtnl_talk to support malloc buff at run time") Signed-off-by: Chris Mi Reviewed-by: Jiri Pirko --- tc/m_action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_action.c b/tc/m_action.c index afb6cfad..986ef7d0 100644 --- a/tc/m_action.c +++ b/tc/m_action.c @@ -529,7 +529,7 @@ static int tc_action_gd(int cmd, unsigned int flags, req.n.nlmsg_seq = rth.dump = ++rth.seq; - if (rtnl_talk(&rth, &req.n, &ans) < 0) { + if (rtnl_talk(&rth, &req.n, cmd == RTM_DELACTION ? NULL : &ans) < 0) { fprintf(stderr, "We have an error talking to the kernel\n"); return 1; } -- 2.14.3