From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net 2/3] net: sched: Move to new offload indication in RED Date: Thu, 14 Dec 2017 15:07:23 +0100 Message-ID: <20171214140723.GH1926@nanopsycho> References: <1513259671-1183-1-git-send-email-yuvalm@mellanox.com> <1513259671-1183-3-git-send-email-yuvalm@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org, mlxsw@mellanox.com To: Yuval Mintz Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:36963 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbdLNOHZ (ORCPT ); Thu, 14 Dec 2017 09:07:25 -0500 Received: by mail-wr0-f193.google.com with SMTP id k61so5247904wrc.4 for ; Thu, 14 Dec 2017 06:07:25 -0800 (PST) Content-Disposition: inline In-Reply-To: <1513259671-1183-3-git-send-email-yuvalm@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Dec 14, 2017 at 02:54:30PM CET, yuvalm@mellanox.com wrote: >Let RED utilize the new internal flag, TCQ_F_OFFLOADED, >to mark a given qdisc as offloaded instead of using a dedicated >indication. > >Also, change internal logic into looking at said flag when possible. > >Fixes: 602f3baf2218 ("net_sch: red: Add offload ability to RED qdisc") >Signed-off-by: Yuval Mintz Acked-by: Jiri Pirko Note that it would be good to add red offload presence in drivers (mlxsw) and forbid to disable tc offload feature in that case.