From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Subject: [PATCHv2 net-next 02/15] lib: nlattr: set extack msg if validate_nla fails Date: Thu, 14 Dec 2017 13:38:52 -0500 Message-ID: <20171214183905.23066-3-aring@mojatatu.com> References: <20171214183905.23066-1-aring@mojatatu.com> Cc: xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com, Alexander Aring To: jhs@mojatatu.com Return-path: Received: from mail-it0-f66.google.com ([209.85.214.66]:33391 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753743AbdLNSjk (ORCPT ); Thu, 14 Dec 2017 13:39:40 -0500 Received: by mail-it0-f66.google.com with SMTP id o130so26336504itg.0 for ; Thu, 14 Dec 2017 10:39:40 -0800 (PST) In-Reply-To: <20171214183905.23066-1-aring@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: This patch sets a generic netlink error message if the validation of the netlink attribute failed. It avoids several different settings of netlink messages by handle nla_parse_nested on error case. Suggested-by: David Ahern Signed-off-by: Alexander Aring --- lib/nlattr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/nlattr.c b/lib/nlattr.c index dfa55c873c13..a2a9506b2fb7 100644 --- a/lib/nlattr.c +++ b/lib/nlattr.c @@ -253,8 +253,10 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head, if (policy) { err = validate_nla(nla, maxtype, policy); if (err < 0) { - if (extack) + if (extack) { + NL_SET_ERR_MSG(extack, "Failed to validate netlink attribute"); extack->bad_attr = nla; + } goto errout; } } -- 2.11.0