From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [patch iproute2] tc: fix command "tc actions del" hang issue Date: Thu, 14 Dec 2017 21:16:58 -0800 Message-ID: <20171214211658.40eb8290@xeon-e3> References: <20171214090900.14336-1-chrism@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jiri@resnulli.us To: Chris Mi Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:40517 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbdLOFRB (ORCPT ); Fri, 15 Dec 2017 00:17:01 -0500 Received: by mail-pf0-f193.google.com with SMTP id v26so5394748pfl.7 for ; Thu, 14 Dec 2017 21:17:00 -0800 (PST) In-Reply-To: <20171214090900.14336-1-chrism@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 14 Dec 2017 18:09:00 +0900 Chris Mi wrote: > If command is RTM_DELACTION, a non-NULL pointer is passed to rtnl_talk(). > Then flag NLM_F_ACK is not set on n->nlmsg_flags and netlink_ack() will > not be called. Command tc will wait for the reply for ever. > > Fixes: 86bf43c7c2fd ("lib/libnetlink: update rtnl_talk to support malloc > buff at run time") > Signed-off-by: Chris Mi > Reviewed-by: Jiri Pirko Thanks for fixing this. Applied, but please don't linewrap the fixes tag.