From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: phy: marvell: enable a errata for 88E1145 Date: Fri, 15 Dec 2017 10:47:04 -0500 (EST) Message-ID: <20171215.104704.651511100967508376.davem@davemloft.net> References: <20171215061332.42133-1-qiang.zhao@nxp.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org To: qiang.zhao@nxp.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:51888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932168AbdLOPrG (ORCPT ); Fri, 15 Dec 2017 10:47:06 -0500 In-Reply-To: <20171215061332.42133-1-qiang.zhao@nxp.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Zhao Qiang Date: Fri, 15 Dec 2017 14:13:32 +0800 > The patch below > commit f2899788353c ("net: phy: marvell: Limit errata to 88m1101") > limit a errata's scope to 88E1101. > However, 88E1145 also need this errata, set config_aneg to > m88e1101_config_aneg for 88E1145 > > Signed-off-by: Zhao Qiang The proper way to say that a patch fixes a particular commit it to reference it in a "Fixes: " tag, like this: ==================== Fixes: f2899788353c ("net: phy: marvell: Limit errata to 88m1101") Signed-off-by: Zhao Qiang ==================== And then you don't need to reference it explicitly in your commit message, you can just instead say: Limit 88m1101 autoneg errata to 88E1145 as well. Please fix up your submission like this and resubmit. Thank you.