From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 0/3] net: sched: Make qdisc offload uapi uniform Date: Fri, 15 Dec 2017 13:36:24 -0500 (EST) Message-ID: <20171215.133624.909968538603448658.davem@davemloft.net> References: <1513259671-1183-1-git-send-email-yuvalm@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, mlxsw@mellanox.com To: yuvalm@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54698 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755406AbdLOSg0 (ORCPT ); Fri, 15 Dec 2017 13:36:26 -0500 In-Reply-To: <1513259671-1183-1-git-send-email-yuvalm@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Yuval Mintz Date: Thu, 14 Dec 2017 15:54:28 +0200 > Several qdiscs can already be offloaded to hardware, but there's an > inconsistecy in regard to the uapi through which they indicate such > an offload is taking place - indication is passed to the user via > TCA_OPTIONS where each qdisc retains private logic for setting it. > > The recent addition of offloading to RED in > 602f3baf2218 ("net_sch: red: Add offload ability to RED qdisc") caused > the addition of yet another uapi field for this purpose - > TC_RED_OFFLOADED. > > For clarity and prevention of bloat in the uapi we want to eliminate > said added uapi, replacing it with a common mechanism that can be used > to reflect offload status of the various qdiscs. > > The first patch introduces TCA_HW_OFFLOAD as the generic message meant > for this purpose. The second changes the current RED implementation into > setting the internal bits necessary for passing it, and the third removes > TC_RED_OFFLOADED as its no longer needed. > > Dave, > > A bit unorthodox as it's not a fix per-se, but it's the last chance > for killing the unneeded uapi and replacing it with something better > before getting stuck with it forever. I agree, let's take care of this now while we can. Series applied, thanks.