From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [patch net 1/2] net: sched: fix clsact init error path
Date: Fri, 15 Dec 2017 15:44:49 -0500 (EST)
Message-ID: <20171215.154449.1971297738166148632.davem@davemloft.net>
References: <20171215114013.6425-1-jiri@resnulli.us>
        <20171215114013.6425-2-jiri@resnulli.us>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
        mlxsw@mellanox.com, daniel@iogearbox.net
To: jiri@resnulli.us
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:56660 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755650AbdLOUov (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 15 Dec 2017 15:44:51 -0500
In-Reply-To: <20171215114013.6425-2-jiri@resnulli.us>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 15 Dec 2017 12:40:12 +0100

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Since in qdisc_create, the destroy op is called when init fails, we
> don't do cleanup in init and leave it up to destroy.
> This fixes use-after-free when trying to put already freed block.
> 
> Fixes: 6e40cf2d4dee ("net: sched: use extended variants of block_get/put in ingress and clsact qdiscs")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Applied.