From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH net-next] net: phy: phylink: Handle NULL fwnode_handle Date: Fri, 15 Dec 2017 00:25:06 +0000 Message-ID: <20171215002506.GR10595@n2100.armlinux.org.uk> References: <20171214235758.26122-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Andrew Lunn , open list To: Florian Fainelli Return-path: Received: from pandora.armlinux.org.uk ([78.32.30.218]:56112 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754431AbdLOAZR (ORCPT ); Thu, 14 Dec 2017 19:25:17 -0500 Content-Disposition: inline In-Reply-To: <20171214235758.26122-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Dec 14, 2017 at 03:57:58PM -0800, Florian Fainelli wrote: > Unlike the various of_* routines to fetch properties, fwnode_* routines can > have an early check against a NULL fwnode_handle reference which makes them > return -EINVAL (see fwnode_call_int_op), thus making it virtually impossible to > differentiate what type of error is going on. > > Have an early check in phylink_register_sfp() so we can keep proceeding with > the initialization, there is not much we can do without a valid fwnode_handle > except return early and treat this similarly to -ENOENT. > > Fixes: 8fa7b9b6af25 ("phylink: convert to fwnode") > Signed-off-by: Florian Fainelli Acked-by: Russell King Thanks Florian. > --- > drivers/net/phy/phylink.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c > index c89b8c63f16a..69adc0aa141c 100644 > --- a/drivers/net/phy/phylink.c > +++ b/drivers/net/phy/phylink.c > @@ -506,6 +506,9 @@ static int phylink_register_sfp(struct phylink *pl, > struct fwnode_reference_args ref; > int ret; > > + if (!fwnode) > + return 0; > + > ret = fwnode_property_get_reference_args(fwnode, "sfp", NULL, > 0, 0, &ref); > if (ret < 0) { > -- > 2.14.1 > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up