From: Andrew Lunn <andrew@lunn.ch>
To: Sean Wang <sean.wang@mediatek.com>
Cc: sergei.shtylyov@cogentembedded.com, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, richard.leitner@skidata.com,
geert+renesas@glider.be
Subject: Re: [net-next] phylib: Add device reset GPIO support causes DSA MT7530 acquires reset-gpios fails
Date: Fri, 15 Dec 2017 11:10:14 +0100 [thread overview]
Message-ID: <20171215101014.GB4213@lunn.ch> (raw)
In-Reply-To: <1513320903.28444.65.camel@mtkswgap22>
On Fri, Dec 15, 2017 at 02:55:03PM +0800, Sean Wang wrote:
> Hi Sergei,
>
> Recently I found the patch commit bafbdd527d56 (phylib: Add device reset
> GPIO support) would have the impact on MT7530 driver. Which causes the
> DSA MT7530 device (it's the child node under mdio bus) gets the
> reset-gpios fails because the same GPIO seems already be held in the
> earlier mdiobus_register_device call patched through the commit.
>
> do you have any idea how the commits also considers DSA case ?
>
> I guessed the DSA lan9303, mv88e8 switch should have the same issue
> since they have the same GPIO name as mdiobus_register_device required.
Hi Sean
Ah, not good :-(
I _think_ for the mv88e6xxx, we can remove the gpio reset code from
the driver, and let the mdio core do it. I need to test to be sure.
Would that work for you?
Andrew
next prev parent reply other threads:[~2017-12-15 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 6:55 [net-next] phylib: Add device reset GPIO support causes DSA MT7530 acquires reset-gpios fails Sean Wang
2017-12-15 10:10 ` Andrew Lunn [this message]
2017-12-18 4:01 ` Sean Wang
2017-12-18 8:01 ` Andrew Lunn
2017-12-18 19:21 ` Florian Fainelli
2017-12-19 9:06 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215101014.GB4213@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=sean.wang@mediatek.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).