From: Pavel Machek <pavel@ucw.cz>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: Gabriel C <nix.or.die@gmail.com>,
kernel list <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: v4.15-rc2 on thinkpad x60: ethernet stopped working
Date: Fri, 15 Dec 2017 20:04:51 +0100 [thread overview]
Message-ID: <20171215190451.GA14423@amd> (raw)
In-Reply-To: <02874ECE860811409154E81DA85FBB5882B5FB49@ORSMSX115.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
Hi!
> > > > Any ideas ?
> > >
> > > Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it.
> > >
> > > See:
> > > https://bugzilla.kernel.org/show_bug.cgi?id=198047
> > >
> > > Fix there :
> > > https://marc.info/?l=linux-kernel&m=151272209903675&w=2
> > >
> > > Regards,
> > >
> > > Gabriel C
> >
> > Hi,
> >
> > Digging into this, the problem is complicated. The original bug assumed behavior
> > of the .check_for_link call, which is universally not implemented.
> >
> > I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate signaling for
> > link check/link up", 2017-10-10) and find a more proper solution.
> >
> > I don't think any other code which uses check_for_link expects the interface to
> > return in the way this patch attempted.
> Alternatively, we can go a step farther and make sure every implementation of .check_for_link follows the modified interface.
>
We are at -rc3 now. Reverting 19110cfbb34d seems like good solution at
the moment.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-12-15 19:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 8:39 v4.15-rc2 on thinkpad x60: ethernet stopped working Pavel Machek
2017-12-10 12:44 ` Gabriel C
2017-12-15 9:28 ` Pavel Machek
2017-12-15 15:52 ` David Miller
2017-12-18 10:26 ` Pavel Machek
[not found] ` <5c0be4c4-5a56-cc7b-7b5a-345f446e788e@intel.com>
2017-12-18 11:58 ` [Intel-wired-lan] " Pavel Machek
2017-12-18 15:50 ` Neftin, Sasha
2017-12-18 17:07 ` Fujinaka, Todd
2017-12-20 15:54 ` Pavel Machek
2017-12-20 16:01 ` Pavel Machek
2017-12-21 7:13 ` Neftin, Sasha
2017-12-20 6:24 ` Neftin, Sasha
2017-12-15 17:29 ` Keller, Jacob E
2017-12-15 17:30 ` Keller, Jacob E
2017-12-15 19:04 ` Pavel Machek [this message]
2017-12-21 9:40 ` [Intel-wired-lan] " Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215190451.GA14423@amd \
--to=pavel@ucw.cz \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nix.or.die@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).