From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] vxlan: restore dev->mtu setting based on lower
 device
Date: Sat, 16 Dec 2017 23:05:45 -0500 (EST)
Message-ID: <20171216.230545.886181859330965948.davem@davemloft.net>
References: <1513272000-30848-1-git-send-email-alexey.kodanev@oracle.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, sbrivio@redhat.com,
        mschiffer@universe-factory.net, juyan@redhat.com, jbenc@redhat.com,
        haliu@redhat.com
To: alexey.kodanev@oracle.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:46806 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757081AbdLQEFr (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 16 Dec 2017 23:05:47 -0500
In-Reply-To: <1513272000-30848-1-git-send-email-alexey.kodanev@oracle.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Alexey Kodanev <alexey.kodanev@oracle.com>
Date: Thu, 14 Dec 2017 20:20:00 +0300

> Stefano Brivio says:
>     Commit a985343ba906 ("vxlan: refactor verification and
>     application of configuration") introduced a change in the
>     behaviour of initial MTU setting: earlier, the MTU for a link
>     created on top of a given lower device, without an initial MTU
>     specification, was set to the MTU of the lower device minus
>     headroom as a result of this path in vxlan_dev_configure():
> 
> 	if (!conf->mtu)
> 		dev->mtu = lowerdev->mtu -
> 			   (use_ipv6 ? VXLAN6_HEADROOM : VXLAN_HEADROOM);
> 
>     which is now gone. Now, the initial MTU, in absence of a
>     configured value, is simply set by ether_setup() to ETH_DATA_LEN
>     (1500 bytes).
> 
>     This breaks userspace expectations in case the MTU of
>     the lower device is higher than 1500 bytes minus headroom.
> 
> This patch restores the previous behaviour on newlink operation. Since
> max_mtu can be negative and we update dev->mtu directly, also check it
> for valid minimum.
> 
> Reported-by: Junhan Yan <juyan@redhat.com>
> Fixes: a985343ba906 ("vxlan: refactor verification and application of configuration")
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>

Applied and queued up for -stable, thanks.