From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 0/3] Improve tunnel local/remote endpoint params and gre link attribute handling Date: Sat, 16 Dec 2017 10:10:08 -0800 Message-ID: <20171216101008.4b32dcd8@xeon-e3> References: <1513193762-1580-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Serhey Popovych Return-path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:33273 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756834AbdLPSKK (ORCPT ); Sat, 16 Dec 2017 13:10:10 -0500 Received: by mail-pl0-f65.google.com with SMTP id 1so899038plv.0 for ; Sat, 16 Dec 2017 10:10:10 -0800 (PST) In-Reply-To: <1513193762-1580-1-git-send-email-serhe.popovych@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 13 Dec 2017 21:35:59 +0200 Serhey Popovych wrote: > In this series following problems addressed: > > 1) Size of IFLA_GRE_LINK attribute is 32 bits long in , not 8 bit. > > 2) Use get_addr() instead of get_prefix() to parse local/remote > tunnel endpoints as IPADDR, not PREFIX as per ip-link(8). > > 3) No need to check if local/remote endpoints are zero (e.g. INADDR_ANY): > it is fully legal value, accepted by the kernel. > > See individual patch description message for details. > > Thanks, > Serhii > > Serhey Popovych (3): > ip/tunnel: Unify setup and accept zero address for local/remote > endpoints > ip/tunnel: Use get_addr() instead of get_prefix() for local/remote > endpoints > ip: gre: fix IFLA_GRE_LINK attribute sizing > > ip/ip6tunnel.c | 8 ++------ > ip/iptunnel.c | 10 ++-------- > ip/link_gre.c | 8 +++----- > ip/link_gre6.c | 8 ++------ > ip/link_ip6tnl.c | 12 ++++-------- > ip/link_iptnl.c | 10 ++-------- > ip/link_vti.c | 14 ++------------ > ip/link_vti6.c | 26 ++++++++------------------ > 8 files changed, 25 insertions(+), 71 deletions(-) > Looks good, applied