From: kbuild test robot <lkp@intel.com>
To: Shannon Nelson <shannon.nelson@oracle.com>
Cc: kbuild-all@01.org, steffen.klassert@secunet.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 ipsec-next 3/3] xfrm: wrap xfrmdev_ops with offload config
Date: Sun, 17 Dec 2017 03:12:34 +0800 [thread overview]
Message-ID: <201712170317.SLwe6dgx%fengguang.wu@intel.com> (raw)
In-Reply-To: <1513285277-21092-4-git-send-email-shannon.nelson@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 2585 bytes --]
Hi Shannon,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on ipsec-next/master]
url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/xfrm-check-for-xdo_dev_state_free/20171217-022754
base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
config: x86_64-randconfig-x014-201751 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
net/xfrm/xfrm_device.c: In function 'xfrm_dev_feat_change':
>> net/xfrm/xfrm_device.c:172:48: error: 'struct net_device' has no member named 'xfrmdev_ops'; did you mean 'l3mdev_ops'?
if ((dev->features & NETIF_F_HW_ESP) && !dev->xfrmdev_ops)
^~~~~~~~~~~
l3mdev_ops
net/xfrm/xfrm_device.c:175:8: error: 'struct net_device' has no member named 'xfrmdev_ops'; did you mean 'l3mdev_ops'?
dev->xfrmdev_ops = NULL;
^~~~~~~~~~~
l3mdev_ops
vim +172 net/xfrm/xfrm_device.c
d77e38e6 Steffen Klassert 2017-04-14 169
d77e38e6 Steffen Klassert 2017-04-14 170 static int xfrm_dev_feat_change(struct net_device *dev)
d77e38e6 Steffen Klassert 2017-04-14 171 {
d77e38e6 Steffen Klassert 2017-04-14 @172 if ((dev->features & NETIF_F_HW_ESP) && !dev->xfrmdev_ops)
d77e38e6 Steffen Klassert 2017-04-14 173 return NOTIFY_BAD;
d77e38e6 Steffen Klassert 2017-04-14 174 else if (!(dev->features & NETIF_F_HW_ESP))
d77e38e6 Steffen Klassert 2017-04-14 175 dev->xfrmdev_ops = NULL;
d77e38e6 Steffen Klassert 2017-04-14 176
d77e38e6 Steffen Klassert 2017-04-14 177 if ((dev->features & NETIF_F_HW_ESP_TX_CSUM) &&
d77e38e6 Steffen Klassert 2017-04-14 178 !(dev->features & NETIF_F_HW_ESP))
d77e38e6 Steffen Klassert 2017-04-14 179 return NOTIFY_BAD;
d77e38e6 Steffen Klassert 2017-04-14 180
d77e38e6 Steffen Klassert 2017-04-14 181 return NOTIFY_DONE;
d77e38e6 Steffen Klassert 2017-04-14 182 }
d77e38e6 Steffen Klassert 2017-04-14 183
:::::: The code at line 172 was first introduced by commit
:::::: d77e38e612a017480157fe6d2c1422f42cb5b7e3 xfrm: Add an IPsec hardware offloading API
:::::: TO: Steffen Klassert <steffen.klassert@secunet.com>
:::::: CC: Steffen Klassert <steffen.klassert@secunet.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34262 bytes --]
next prev parent reply other threads:[~2017-12-16 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 21:01 [PATCH v2 ipsec-next 0/3] xfrm: offload api fixes Shannon Nelson
2017-12-14 21:01 ` [PATCH v2 ipsec-next 1/3] xfrm: check for xdo_dev_state_free Shannon Nelson
2017-12-14 21:01 ` [PATCH v2 ipsec-next 2/3] xfrm: check for xdo_dev_ops add and delete Shannon Nelson
2017-12-14 21:01 ` [PATCH v2 ipsec-next 3/3] xfrm: wrap xfrmdev_ops with offload config Shannon Nelson
2017-12-16 19:12 ` kbuild test robot [this message]
2017-12-16 20:04 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201712170317.SLwe6dgx%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@oracle.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox