Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lorenzo@google.com
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com,
	subashab@codeaurora.org, nharold@google.com
Subject: Re: [RFC ipsec-next 3/4] net: xfrm: support multiple VTI tunnels
Date: Mon, 18 Dec 2017 12:56:42 -0500 (EST)	[thread overview]
Message-ID: <20171218.125642.639075398593924537.davem@davemloft.net> (raw)
In-Reply-To: <20171218161656.40618-4-lorenzo@google.com>

From: Lorenzo Colitti <lorenzo@google.com>
Date: Tue, 19 Dec 2017 01:16:55 +0900

> - ICMP errors are similar to input, except the search is for the
>   outbound XFRM state, because the only data that is available is
>   the outbound SPI. Thus, ICMP errors are only processed if the
>   ikey is the same as the same as the okey. AFAICS this is
>   consistent with GRE tunnels, but not with existing VTI
>   behaviour.

I think you will need to sort out the VTI ICMP behavior difference
with what exists now.

  reply	other threads:[~2017-12-18 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 16:16 [RFC ipsec-next 0/4]: Support multiple VTIs with the same src+dst pair Lorenzo Colitti
2017-12-18 16:16 ` [RFC ipsec-next 1/4] met: xfrm: Add an xfrm lookup that ignores the mark Lorenzo Colitti
2017-12-18 16:16 ` [RFC ipsec-next 2/4] net: xfrm: find VTI interfaces from xfrm_input Lorenzo Colitti
2017-12-18 16:16 ` [RFC ipsec-next 3/4] net: xfrm: support multiple VTI tunnels Lorenzo Colitti
2017-12-18 17:56   ` David Miller [this message]
2017-12-20 17:12     ` Lorenzo Colitti
2017-12-18 16:16 ` [RFC ipsec-next 4/4] net: xfrm: don't pass tunnel objects to xfrm6_rcv_spi Lorenzo Colitti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171218.125642.639075398593924537.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nharold@google.com \
    --cc=steffen.klassert@secunet.com \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox