From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [net 1/1] tipc: remove leaving group member from all lists
Date: Mon, 18 Dec 2017 13:17:15 -0500 (EST)
Message-ID: <20171218.131715.1473690568653475583.davem@davemloft.net>
References: <1513617214-15464-1-git-send-email-jon.maloy@ericsson.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org,
        mohan.krishna.ghanta.krishnamurthy@ericsson.com,
        tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au,
        canh.d.luu@dektech.com.au, ying.xue@windriver.com,
        tipc-discussion@lists.sourceforge.net
To: jon.maloy@ericsson.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:38936 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933482AbdLRSRR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 18 Dec 2017 13:17:17 -0500
In-Reply-To: <1513617214-15464-1-git-send-email-jon.maloy@ericsson.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jon Maloy <jon.maloy@ericsson.com>
Date: Mon, 18 Dec 2017 18:13:34 +0100

> A group member going into state LEAVING should never go back to any
> other state before it is finally deleted. However, this might happen
> if the socket needs to send out a RECLAIM message during this interval.
> Since we forget to remove the leaving member from the group's 'active'
> or 'pending' list, the member might be selected for reclaiming, change
> state to RECLAIMING, and get stuck in this state instead of being
> deleted. This might lead to suppression of the expected 'member down'
> event to the receiver.
> 
> We fix this by removing the member from all lists, except the RB tree,
> at the moment it goes into state LEAVING.
> 
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>

Also applied, thanks Jon.