Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hpuranik@codeaurora.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	timur@codeaurora.org
Subject: Re: [PATCH] net: qcom/emac: Change the order of mac up and sgmii open
Date: Mon, 18 Dec 2017 13:22:09 -0500 (EST)	[thread overview]
Message-ID: <20171218.132209.907707924433000658.davem@davemloft.net> (raw)
In-Reply-To: <1513576667-2967-1-git-send-email-hpuranik@codeaurora.org>

From: Hemanth Puranik <hpuranik@codeaurora.org>
Date: Mon, 18 Dec 2017 11:27:47 +0530

> This patch fixes the order of mac_up and sgmii_open for the
> reasons noted below:
> 
> - If open takes more time(if the SGMII block is not responding or
>   if we want to do some delay based task) in this situation we
>   will hit NETDEV watchdog
> - The main reason : We should signal to upper layers that we are
>   ready to receive packets "only" when the entire path is initialized
>   not the other way around, this is followed in the reset path where
>   we do mac_down, sgmii_reset and mac_up. This also makes the driver
>   uniform across the reset and open paths.
> - In the future there may be need for delay based tasks to be done in
>   sgmii open which will result in NETDEV watchdog
> - As per the documentation the order of init should be sgmii, mac, rings
>   and DMA
> 
> Signed-off-by: Hemanth Puranik <hpuranik@codeaurora.org>

Applied.

      parent reply	other threads:[~2017-12-18 18:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18  5:57 [PATCH] net: qcom/emac: Change the order of mac up and sgmii open Hemanth Puranik
2017-12-18 16:05 ` Timur Tabi
2017-12-18 18:22 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171218.132209.907707924433000658.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hpuranik@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox