[PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

[PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

[Xin Long]

Whenever a new type of chunk is added, the corresp conversion in
sctp_cname should be added. Otherwise, in some places, pr_debug
will print it as "unknown chunk".

Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
 net/sctp/debug.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/sctp/debug.c b/net/sctp/debug.c
index 3f619fd..291c97b 100644
--- a/net/sctp/debug.c
+++ b/net/sctp/debug.c
@@ -78,6 +78,9 @@ const char *sctp_cname(const union sctp_subtype cid)
 	case SCTP_CID_AUTH:
 		return "AUTH";
 
+	case SCTP_CID_RECONF:
+		return "RECONF";
+
 	default:
 		break;
 	}
-- 
2.1.0

Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

[Marcelo Ricardo Leitner]

On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
> 
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>

...
>  	case SCTP_CID_AUTH:
>  		return "AUTH";
>  
> +	case SCTP_CID_RECONF:
> +		return "RECONF";
> +
>  	default:
>  		break;

Now we also need idata and ifwdtsn in there too, btw.

  Marcelo

Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

[Neil Horman]

On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
> 
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
>  net/sctp/debug.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 3f619fd..291c97b 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -78,6 +78,9 @@ const char *sctp_cname(const union sctp_subtype cid)
>  	case SCTP_CID_AUTH:
>  		return "AUTH";
>  
> +	case SCTP_CID_RECONF:
> +		return "RECONF";
> +
>  	default:
>  		break;
>  	}
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

[David Miller]

From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 18 Dec 2017 14:13:17 +0800

> Whenever a new type of chunk is added, the corresp conversion in
> sctp_cname should be added. Otherwise, in some places, pr_debug
> will print it as "unknown chunk".
> 
> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>

Applied.

Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

[Xin Long]

On Mon, Dec 18, 2017 at 9:08 PM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote:
>> Whenever a new type of chunk is added, the corresp conversion in
>> sctp_cname should be added. Otherwise, in some places, pr_debug
>> will print it as "unknown chunk".
>>
>> Fixes: cc16f00f6529 ("sctp: add support for generating stream reconf ssn reset request chunk")
>> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Acked-by: Marcelo R. Leitner <marcelo.leitner@gmail.com>
>
> ...
>>       case SCTP_CID_AUTH:
>>               return "AUTH";
>>
>> +     case SCTP_CID_RECONF:
>> +             return "RECONF";
>> +
>>       default:
>>               break;
>
> Now we also need idata and ifwdtsn in there too, btw.
Yes, waiting for the merge from net-next to net.

>
>   Marcelo