From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [Intel-wired-lan] [bpf-next V1-RFC PATCH 03/14] i40e: setup
 xdp_rxq_info
Date: Mon, 18 Dec 2017 14:05:56 +0100
Message-ID: <20171218140556.51cef95c@redhat.com>
References: <151316391502.14967.13292358380181773729.stgit@firesoul>
        <151316397618.14967.13648763339440521538.stgit@firesoul>
        <CAJ+HfNgYvuHP72g04ZH1DR_svQtnSPi1Z_TqLVDvS-L9ijvh=A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Cc: Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Netdev <netdev@vger.kernel.org>,
        intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
        dsahern@gmail.com, gospo@broadcom.com,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@intel.com>,
        michael.chan@broadcom.com,
        "Karlsson, Magnus" <magnus.karlsson@intel.com>, brouer@redhat.com
To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:37350 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751376AbdLRNGF (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 18 Dec 2017 08:06:05 -0500
In-Reply-To: <CAJ+HfNgYvuHP72g04ZH1DR_svQtnSPi1Z_TqLVDvS-L9ijvh=A@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 18 Dec 2017 11:52:08 +0100
Björn Töpel <bjorn.topel@gmail.com> wrote:

> > +       /* Flow director side channel does not invoke XDP/bpf */
> > +       if (rx_ring->vsi->type == I40E_VSI_FDIR)
> > +               xdp_rxq_info_type(&rx_ring->xdp_rxq, RXQ_TYPE_SINK);  
> 
> For me, it doesn't make sense to expose the FD Rx ring outside the
> scope of i40e driver. Check against VSI_MAIN in setup/cleanup so the
> FD ring is not exposed outside the driver. Maybe you can get rid of
> the RXQ_TYPE_SINK as well then.

Okay, took this advice and changed patch to instead check against
I40E_VSI_MAIN.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer