From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com, Thomas Graf <tgraf@suug.ch>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] rhashtable: Add rhashtable_walk_curr
Date: Tue, 19 Dec 2017 10:38:40 +1100 [thread overview]
Message-ID: <20171218233840.GA25632@gondor.apana.org.au> (raw)
In-Reply-To: <20171218133122.29179-2-agruenba@redhat.com>
On Mon, Dec 18, 2017 at 02:31:21PM +0100, Andreas Gruenbacher wrote:
> When iterating through an rhashtable is stopped with
> rhashtable_walk_stop and then resumed with rhashtable_walk_start, there
> currently is no way to get back to the current object and thus revisit
> the object rhashtable_walk_next has previously returned.
>
> This functionality is useful when dumping an rhashtable via the seq file
> interface: seq_read will convert one object after the other. When an
> object doesn't fit in the remaining buffer space anymore, user-space
> will be returned all objects that have been fully converted so far.
> Upon the next read from user-space, the object that didn't fit
> previously will be revisited.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Doesn't the helper that Tom Herbert just added do exactly this?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-12-18 23:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171218133122.29179-1-agruenba@redhat.com>
2017-12-18 13:31 ` [PATCH 2/3] rhashtable: Add rhashtable_walk_curr Andreas Gruenbacher
2017-12-18 23:38 ` Herbert Xu [this message]
2017-12-19 8:35 ` Andreas Gruenbacher
2017-12-19 14:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218233840.GA25632@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox