From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [patch net-next] mlxsw: spectrum: Add "spectrum" prefix macro
Date: Tue, 19 Dec 2017 11:09:06 -0500 (EST)
Message-ID: <20171219.110906.560509930655165996.davem@davemloft.net>
References: <20171217161534.2446-1-jiri@resnulli.us>
        <1513527900.31581.27.camel@perches.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: jiri@resnulli.us, netdev@vger.kernel.org, arkadis@mellanox.com,
        idosch@mellanox.com, mlxsw@mellanox.com
To: joe@perches.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:52506 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751035AbdLSQJH (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 19 Dec 2017 11:09:07 -0500
In-Reply-To: <1513527900.31581.27.camel@perches.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Joe Perches <joe@perches.com>
Date: Sun, 17 Dec 2017 08:25:00 -0800

> On Sun, 2017-12-17 at 17:15 +0100, Jiri Pirko wrote:
>> From: Arkadi Sharshevsky <arkadis@mellanox.com>
>> 
>> Add "spectrum" string prefix macro for error strings.
> []
>> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
> []
>> @@ -4168,13 +4168,11 @@ mlxsw_sp_master_lag_check(struct mlxsw_sp *mlxsw_sp,
>>  	u16 lag_id;
>>  
>>  	if (mlxsw_sp_lag_index_get(mlxsw_sp, lag_dev, &lag_id) != 0) {
>> -		NL_SET_ERR_MSG(extack,
>> -			       "spectrum: Exceeded number of supported LAG devices");
>> +		NL_SET_ERR_MSG(extack, MLXSW_SP_PREFIX "Exceeded number of supported LAG devices");
> 
> Perhaps use NL_SET_ERR_MSG_MOD instead.

Yeah that probably makes sense.